Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All pending dacite PRs #200

Closed
wants to merge 19 commits into from
Closed

All pending dacite PRs #200

wants to merge 19 commits into from

Conversation

idanmiara
Copy link

Hi @konradhalas,

I've opened this PR in case you wanted to merge this to the official release.
idanmiara#1

Thanks :)

antonagestam and others added 19 commits November 30, 2022 22:18
Reproducible build fails if the file is encoded differently depending on the current locale settings when reading README.md.
test for type_hook with initVar added
added tests for type hinting with generic collections
- Remove unused type: ignore.
- Remove asterisk import and add `__all__` with all exported names, to
  pass with the `no_explicit_reexport` mypy flag.
- Add various mypy config for developer ergonomics (prettier errors,
  printing error codes, warning about unused config, ignores and casts
  etc). Kept `warn_return_any = False` in `dacite.types` for now since there
  would have to be a lot of ignores/casts otherwise.
Also add a test to help ensure that type_hooks continues to work with a
very general Mapping implementation.
allow `is_instance` checks for arbitrary generic types
add test for `npt.NDArray` handling
mark 2 tests with `init_var_type_support`
@konradhalas
Copy link
Owner

@idanmiara thank you - I'm on it, but I have to review all PR/issues first, so I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.